On 6/29/24 11:39 AM, Erez Geva wrote: > From: Erez Geva <ErezGeva2@xxxxxxxxx> > > Functions: > > - Send an opcode > > - Read a register > > - Write a register Don't use the commit message as a continuation of the subject. Describe your changes. Convince the reviewer why you need to change core methods and that it makes sense for them to read past the first paragraph. You ignored the feedback from v1, I'm marking this as changes requested and ignore the rest.
