Hi Dragan,
Am Samstag, 29. Juni 2024, 07:11:24 CEST schrieb Dragan Simic:
> +#ifndef RK356X_GPU_NPU_SHARED_REGULATOR
is there some reason for this duplicating of opps?
The regulator framework should pick the lowest supported voltage
anyway, so it seems you're just extending them upwards a bit.
So I really don't so why we'd need to sets here.
Also the voltage-range thing makes sense for non-gpu-npu-sharing
boards, when the supplying regulator does not fully support the
direct single-value voltage.
(rk3399-puma was such a case if I remember correctly)
So I really see no reason for this duplication.
Heiko
> opp-200000000 {
> opp-hz = /bits/ 64 <200000000>;
> opp-microvolt = <825000>;
> @@ -222,6 +229,37 @@ opp-800000000 {
> opp-hz = /bits/ 64 <800000000>;
> opp-microvolt = <1000000>;
> };
> +#else
> + opp-200000000 {
> + opp-hz = /bits/ 64 <200000000>;
> + opp-microvolt = <825000 825000 1000000>;
> + };
> +
> + opp-300000000 {
> + opp-hz = /bits/ 64 <300000000>;
> + opp-microvolt = <825000 825000 1000000>;
> + };
> +
> + opp-400000000 {
> + opp-hz = /bits/ 64 <400000000>;
> + opp-microvolt = <825000 825000 1000000>;
> + };
> +
> + opp-600000000 {
> + opp-hz = /bits/ 64 <600000000>;
> + opp-microvolt = <825000 825000 1000000>;
> + };
> +
> + opp-700000000 {
> + opp-hz = /bits/ 64 <700000000>;
> + opp-microvolt = <900000 900000 1000000>;
> + };
> +
> + opp-800000000 {
> + opp-hz = /bits/ 64 <800000000>;
> + opp-microvolt = <1000000 1000000 1000000>;
> + };
> +#endif /* RK356X_GPU_NPU_SHARED_REGULATOR */
> };
>
> hdmi_sound: hdmi-sound {
>
