Re: [PATCH 1/6] media: dt-bindings: media: camss: Add qcom,sc7280-camss binding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 28/06/2024 19:32, Vikram Sharma wrote:
Add bindings for qcom,sc7280-camss in order to support the camera
subsystem for sc7280.

Signed-off-by: Suresh Vankadara <quic_svankada@xxxxxxxxxxx>
Signed-off-by: Trishansh Bhardwaj <quic_tbhardwa@xxxxxxxxxxx>
Signed-off-by: Vikram Sharma <quic_vikramsa@xxxxxxxxxxx>
---
  .../bindings/media/qcom,sc7280-camss.yaml          | 477 +++++++++++++++++++++
  1 file changed, 477 insertions(+)

diff --git a/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
new file mode 100644
index 000000000000..588c6fb50e2f
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/qcom,sc7280-camss.yaml
@@ -0,0 +1,477 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+
+---
+$id: http://devicetree.org/schemas/media/qcom,sc7280-camss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Technologies, Inc. SC7280 CAMSS ISP
+
+maintainers:
+  - Azam Sadiq Pasha Kapatrala Syed <akapatra@xxxxxxxxxxx>
+  - Hariram Purushothaman <hariramp@xxxxxxxxxxx>
+
+description: |
+  The CAMSS IP is a CSI decoder and ISP present on
+  Qualcomm Technologies, Inc. platforms.
+
+properties:
+  compatible:
+    const: qcom,sc7280-camss
+
+  clocks:
+    minItems: 41
+    maxItems: 41
+
+  clock-names:
+    items:
+
+      - const: cam_hf_axi
+      - const: slow_ahb_src
+      - const: cpas_ahb
+      - const: camnoc_axi_src

You almost certainly don't need to include the "_src" clocks in the list of clocks since the CAMCC driver lists "someclock" as having parent "someclock_src"

+      - const: camnoc_axi
+      - const: csiphy0
+      - const: csiphy0_timer
+      - const: csiphy0_timer_src
+      - const: csiphy1
+      - const: csiphy1_timer
+      - const: csiphy1_timer_src
+      - const: csiphy2
+      - const: csiphy2_timer
+      - const: csiphy2_timer_src
+      - const: csiphy3
+      - const: csiphy3_timer
+      - const: csiphy3_timer_src
+      - const: csiphy4
+      - const: csiphy4_timer
+      - const: csiphy4_timer_src
+      - const: vfe0_csid
+      - const: vfe0_cphy_rx
+      - const: vfe0
+      - const: vfe0_axi
+      - const: csiphy_rx_src
+      - const: vfe1_csid
+      - const: vfe1_cphy_rx
+      - const: vfe1
+      - const: vfe1_axi
+      - const: vfe2_csid
+      - const: vfe2_cphy_rx
+      - const: vfe2
+      - const: vfe2_axi
+      - const: vfe0_lite_csid
+      - const: vfe0_lite_cphy_rx
+      - const: vfe0_lite
+      - const: vfe1_lite_csid
+      - const: vfe1_lite_cphy_rx
+      - const: vfe1_lite
+      - const: vfe_lite0
+      - const: vfe_lite1
+
+  interrupts:
+    minItems: 15
+    maxItems: 15
+
+  interrupt-names:
+    items:
+      - const: csiphy0
+      - const: csiphy1
+      - const: csiphy2
+      - const: csiphy3
+      - const: csiphy4
+      - const: csid0
+      - const: csid1
+      - const: csid2
+      - const: csid_lite0
+      - const: csid_lite1
+      - const: vfe0
+      - const: vfe1
+      - const: vfe2
+      - const: vfe_lite0
+      - const: vfe_lite1
+
+  iommus:
+    maxItems: 1
+
+  interconnects:
+    minItems: 2
+    maxItems: 2
+
+  interconnect-names:
+    items:
+      - const: cam_ahb
+      - const: cam_hf_0
+
+  power-domains:
+    items:
+      - description: IFE0 GDSC - Image Front End, Global Distributed Switch Controller.
+      - description: IFE1 GDSC - Image Front End, Global Distributed Switch Controller.
+      - description: IFE2 GDSC - Image Front End, Global Distributed Switch Controller.
+      - description: Titan GDSC - Titan ISP Block, Global Distributed Switch Controller.

Please name these power domains.

https://lore.kernel.org/linux-arm-msm/fcdb072d-6099-4423-b4b5-21e9052b82cc@xxxxxxxxxx/

---
bod




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux