On 6/26/2024 5:12 PM, Andrew Lunn wrote: > On Wed, Jun 26, 2024 at 04:36:06PM -0700, Sagar Cheluvegowda wrote: >> >> >> On 6/26/2024 6:07 AM, Andrew Lunn wrote: >>>> + plat->axi_icc_path = devm_of_icc_get(&pdev->dev, "axi"); >>>> + if (IS_ERR(plat->axi_icc_path)) { >>>> + ret = (void *)plat->axi_icc_path; >>> >>> Casting to a void * seems odd. ERR_PTR()? >>> >>> Andrew >> >> The output of devm_of_icc_get is a pointer of type icc_path, >> i am getting below warning when i try to ERR_PTR instead of Void* >> as ERR_PTR will try to convert a long integer to a Void*. >> >> "warning: passing argument 1 of ‘ERR_PTR’ makes integer from pointer without a cast" >> > > https://elixir.bootlin.com/linux/v6.10-rc5/source/drivers/crypto/qce/core.c#L224 > https://elixir.bootlin.com/linux/v6.10-rc5/source/drivers/gpu/drm/msm/adreno/a3xx_gpu.c#L591 > https://elixir.bootlin.com/linux/v6.10-rc5/source/drivers/gpu/drm/msm/adreno/a3xx_gpu.c#L597 > https://elixir.bootlin.com/linux/v6.10-rc5/source/drivers/spi/spi-qup.c#L1052 > > Sorry, PTR_ERR(). > > In general, a cast to a void * is a red flag and will get looked > at. It is generally wrong. So you might want to fixup where ever you > copied this from. > > Andrew the return type of stmmac_probe_config_dt is a pointer of type plat_stmmacenet_data, as PTR_ERR would give long integer value i don't think it would be ideal to return an integer value here, if casting plat->axi_icc_path to a void * doesn't look good, let me if the below solution is better or not? plat->axi_icc_path = devm_of_icc_get(&pdev->dev, "axi"); if (IS_ERR(plat->axi_icc_path)) { rc = PTR_ERR(plat->axi_icc_path); ret = ERR_PTR(rc); goto error_hw_init; } plat->ahb_icc_path = devm_of_icc_get(&pdev->dev, "ahb"); if (IS_ERR(plat->ahb_icc_path)) { rc = PTR_ERR(plat->ahb_icc_path); ret = ERR_PTR(rc); goto error_hw_init; } plat->stmmac_rst = devm_reset_control_get_optional(&pdev->dev, STMMAC_RESOURCE_NAME); if (IS_ERR(plat->stmmac_rst)) { ret = plat->stmmac_rst; goto error_hw_init; } plat->stmmac_ahb_rst = devm_reset_control_get_optional_shared( &pdev->dev, "ahb"); if (IS_ERR(plat->stmmac_ahb_rst)) { ret = plat->stmmac_ahb_rst; goto error_hw_init; } return plat; error_hw_init: clk_disable_unprepare(plat->pclk); error_pclk_get: clk_disable_unprepare(plat->stmmac_clk); return ret; } Regards, Sagar