On Fri, 28 Jun 2024 at 18:30, Erez <erezgeva2@xxxxxxxxx> wrote: > > > > On Fri, 28 Jun 2024 at 18:04, Michael Walle <mwalle@xxxxxxxxxx> wrote: >> >> Hi, >> >> On Fri Jun 28, 2024 at 5:57 PM CEST, Conor Dooley wrote: >> > On Fri, Jun 28, 2024 at 04:03:27PM +0200, Erez Geva wrote: >> > > From: Erez Geva <ErezGeva2@xxxxxxxxx> >> > > >> > > Add Macronix SPI-NOR mx25l12833f. >> > > >> > > Signed-off-by: Erez Geva <ErezGeva2@xxxxxxxxx> >> > >> > Should the email in here and in the From: field be your nwtime one? >> > Otherwise >> > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> >> >> Actually, you're not supposed to add any compatibles to this list. >> >> From the binding: >> description: >> SPI NOR flashes compatible with the JEDEC SFDP standard or which may be >> identified with the READ ID opcode (0x9F) do not deserve a specific >> compatible. They should instead only be matched against the generic >> "jedec,spi-nor" compatible. >> >> I presume the Macronix flash does support the read id opcode. > > > Yes, they do support. > The new mx25l12833f also supports SFDP. > > I do not know why they decided to use the same JEDEC ID for two chips. > Your guess is as good as mine. https://www.macronix.com/en-us/products/NOR-Flash/Serial-NOR-Flash/Pages/spec.aspx?p=MX25L12805D&m=Serial%20NOR%20Flash&n=PM1310 End of Life (EOL) https://www.macronix.com/Lists/TechDoc/Attachments/9861/PCN31_2009%20PCN_MX25L6405D%20and%20MX25L12805D.pdf Macronix will continue the support of the existing MX25L6405D and MX25L12805D as the following schedule: The Last Time Order Date: 31st Aug., 2010 The Last Time Shipment Date: 30th Nov., 2010 Erez > > I know the two chips have the same flash size. > Though the new mx25l12833f chip has a bigger OTP. > Secondly, the old mx25l12805d has an asymmetric OTP, the 2 regions are of different size. > > As I see it, the first 2 patches are the real contribution. > As I remember, the kernel maintainers usually like to see something using the code. > I don't care if it was another Macronix chip. I simply tested it with the mx25l12833f chip. > "[PATCH 1/4] Add generic functions for accessing the SPI-NOR chip." > "[PATCH 2/4] Add support for SPI-NOR Macronix OTP." > > I did not think it is important to have a kernel configuration for choosing mx25l12833f over mx25l12805d. > > Erez > > > > > >> >> >> -michael
