On Thu, Jun 27, 2024 at 01:03:01PM -0600, Rob Herring wrote: > On Wed, Jun 26, 2024 at 9:05 AM Serge Semin <fancer.lancer@xxxxxxxxx> wrote: > > > > Hi Rob > > > > On Tue, Jun 25, 2024 at 03:54:41PM -0600, Rob Herring (Arm) wrote: > > > Convention is DT schemas should define all properties at the top-level > > > and not inside of if/then schemas. That minimizes the if/then schemas > > > and is more future proof. > > > > > > Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx> > > > --- > > > .../devicetree/bindings/net/mediatek,net.yaml | 28 +-- > > > > > .../devicetree/bindings/net/snps,dwmac.yaml | 167 +++++++++--------- > > > > For Synopsys DW MACs you can just move the PBL-properties constraints to > > the top-level schema part with no compatible-based conditional > > validation left. It's because the DMA PBL settings are available on all the > > DW MAC IP-cores (DW MAC, DW GMAC, DW QoS Eth, DW XGMAC, DW XLGMAC). > > Moreover the STMMAC driver responsible for the DW MAC device handling > > parses the pbl* properties for all IP-cores irrespective from the > > device compatible string. > > That's definitely better. > Will still need the TSO flag part though, > really, who cares if someone wants to set that on h/w without TSO... Besides the TSO property description is wrong in describing the semantics of the DT-property and MAC HW-capability. The description says that the property enables the TSO feature "otherwise it will be managed by MAC HW capability register." So it means that the "snps,tso" property was supposed to be utilized for force-enabling the TSO feature irrelevant of the MAC HW-capability register data. Instead the STMMAC driver enables the TSO engine only if both "snps,tso" DT-property is specified and the TSO-feature has been detected via the MAC HW capability. > > > > > Alternatively you can just merge in the attached patch, which BTW you > > have already reviewed sometime ago. > > Can you send that to the list since it changed from the last version. Ok. Please find the submitted patch here: https://lore.kernel.org/netdev/20240628154515.8783-1-fancer.lancer@xxxxxxxxx -Serge(y) > > Rob
