Hi, Erez, On 6/28/24 3:03 PM, Erez Geva wrote: > From: Erez Geva <ErezGeva2@xxxxxxxxx> > > Functions: > > - Send a opcode > > - Read a register > > - Write a register > Please describe your changes. You may want to re-read: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#submitting-patches-the-essential-guide-to-getting-your-code-into-the-kernel > Signed-off-by: Erez Geva <ErezGeva2@xxxxxxxxx> > --- > drivers/mtd/spi-nor/core.c | 130 +++++++++++++++++++++++++++---------- > drivers/mtd/spi-nor/core.h | 27 +------- > 2 files changed, 99 insertions(+), 58 deletions(-) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index 028514c6996f..0f267da339a4 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -354,53 +354,134 @@ int spi_nor_write_any_volatile_reg(struct spi_nor *nor, struct spi_mem_op *op, > } > > /** > - * spi_nor_write_enable() - Set write enable latch with Write Enable command. > + * _nor_send_cmd() - Send instruction without address or data to the chip. > * @nor: pointer to 'struct spi_nor'. > + * @opcode: Command to send > * > * Return: 0 on success, -errno otherwise. > */ > -int spi_nor_write_enable(struct spi_nor *nor) > +static inline int _nor_send_cmd(struct spi_nor *nor, u8 opcode) and my review stops here. Why did you think it is good to introduce a _nor* method and not an spi_nor* one? I'm not going to review the rest of the patches. Please send a v2 that convinces me to spend more than 2 minutes on it. Cheers, ta
