On Thu, Jun 27, 2024 at 10:44:44AM GMT, Paul Gerber wrote:
> Add support for the AUO G104STN01 10.4" (800x600) LCD-TFT panel.
>
> Signed-off-by: Paul Gerber <paul.gerber@xxxxxxxxxxxxxxx>
> Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---
> Tested on TQ TQMa8MPxL on MBa8MPxL.
>
> drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index dcb6d0b6ced0..5eacd2085a53 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1081,6 +1081,30 @@ static const struct panel_desc auo_g104sn02 = {
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> };
>
> +static const struct drm_display_mode auo_g104stn01_mode = {
> + .clock = 40000,
Nit: could you please express this as (800 + 40 + 88 + 128) * (600 + 1 + 23 + 4) * 60 / 1000 ?
LGTM otherwise.
> + .hdisplay = 800,
> + .hsync_start = 800 + 40,
> + .hsync_end = 800 + 40 + 88,
> + .htotal = 800 + 40 + 88 + 128,
> + .vdisplay = 600,
> + .vsync_start = 600 + 1,
> + .vsync_end = 600 + 1 + 23,
> + .vtotal = 600 + 1 + 23 + 4,
> +};
> +
> +static const struct panel_desc auo_g104stn01 = {
> + .modes = &auo_g104stn01_mode,
> + .num_modes = 1,
> + .bpc = 8,
> + .size = {
> + .width = 211,
> + .height = 158,
> + },
> + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> + .connector_type = DRM_MODE_CONNECTOR_LVDS,
> +};
> +
> static const struct display_timing auo_g121ean01_timing = {
> .pixelclock = { 60000000, 74400000, 90000000 },
> .hactive = { 1280, 1280, 1280 },
> @@ -4434,6 +4458,9 @@ static const struct of_device_id platform_of_match[] = {
> }, {
> .compatible = "auo,g104sn02",
> .data = &auo_g104sn02,
> + }, {
> + .compatible = "auo,g104stn01",
> + .data = &auo_g104stn01,
> }, {
> .compatible = "auo,g121ean01",
> .data = &auo_g121ean01,
> --
> 2.44.1
>
--
With best wishes
Dmitry
