Hi Krzysztof, Am Freitag, 28. Juni 2024, 09:27:14 CEST schrieb Krzysztof Kozlowski: > On 27/06/2024 23:17, Johan Jonker wrote: > > CLK_NR_CLKS should not be part of the binding. > > Remove since the kernel code no longer uses it. > > Please wrap neither too early nor over the limit. Not one sentence per line. > > > > > > > Signed-off-by: Johan Jonker <jbx6244@xxxxxxxxx> > > --- > > include/dt-bindings/clock/rk3188-cru-common.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/include/dt-bindings/clock/rk3188-cru-common.h b/include/dt-bindings/clock/rk3188-cru-common.h > > index afad90680fce..01e14ab252a7 100644 > > --- a/include/dt-bindings/clock/rk3188-cru-common.h > > +++ b/include/dt-bindings/clock/rk3188-cru-common.h > > @@ -132,8 +132,6 @@ > > #define HCLK_VDPU 472 > > #define HCLK_HDMI 473 > > > > -#define CLK_NR_CLKS (HCLK_HDMI + 1) > > I still see it as being used in linux-next. Some explanation is missing. I think me applying Johan's patch [0] removing the constant's usage, simply overlapped with yesterday's next-creation. [0] https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=for-next&id=ec2265dc91307622e43a7d602c3ea425da6f5de1