On 26/06/2024 11:48, Shan-Chun Hung wrote: > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + mmc@40190000 { > + compatible = "nuvoton,ma35d1-sdhci"; > + reg = <0x0 0x40190000 0x0 0x2000>; > + interrupts = <GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clk SDH1_GATE>; > + pinctrl-names = "default", "state_uhs"; > + pinctrl-0 = <&pinctrl_sdhci1>; > + pinctrl-1 = <&pinctrl_sdhci1_uhs>; > + resets = <&sys MA35D1_RESET_SDH1>; > + nuvoton,sys = <&sys>; > + vqmmc-supply = <&sdhci1_vqmmc_regulator>; > + bus-width = <8>; > + max-frequency = <200000000>; > + status = "disabled"; Again: Drop <form letter> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. </form letter> Best regards, Krzysztof