On Mon, Jun 24, 2024 at 03:30:25AM +0200, Caleb Connolly wrote: > Describe the Samsung AMB655X panel. It has three supplies. > > Signed-off-by: Caleb Connolly <caleb@xxxxxxxxxxxxxxxx> > --- > .../bindings/display/panel/samsung,amb655x.yaml | 59 ++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/samsung,amb655x.yaml b/Documentation/devicetree/bindings/display/panel/samsung,amb655x.yaml > new file mode 100644 > index 000000000000..eb987d022a0d > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/samsung,amb655x.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/samsung,amb655x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung AMB655X 1080x2400 120hz AMOLED panel > + > +maintainers: > + - Caleb Connolly <caleb@xxxxxxxxxxxxxxxx> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + const: samsung,amb655x 'x' is not a wildcard is it? Those are generally not allowed. > + > + reg: > + maxItems: 1 > + > + reset-gpios: > + description: reset gpio, must be GPIO_ACTIVE_LOW blank line > + vddio-supply: true > + vdd-supply: true > + avdd-supply: true > + enable-gpios: true > + port: true > + > +required: > + - compatible > + - reg > + - vdd-supply > + - avdd-supply > + - vddio-supply > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/gpio/gpio.h> > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + panel@0 { > + compatible = "samsung,ams495qa01"; > + reg = <0>; > + reset-gpios = <&gpio4 0 GPIO_ACTIVE_LOW>; > + vdd-supply = <&vcc_3v3>; > + > + port { > + mipi_in_panel: endpoint { > + remote-endpoint = <&mipi_out_panel>; > + }; > + }; > + }; > + }; > + > +... > > -- > 2.45.0 >