On Fri, Jun 21, 2024 at 10:52 AM Frank Li <Frank.Li@xxxxxxx> wrote: > > Add '#power-control-cells' for rcpm: power-control node to fix below You mean #power-domain-cells? > warning. > > power-controller@1ee2140: '#power-domain-cells' is a required property > from schema $id: http://devicetree.org/schemas/power/power-domain.yaml# > > Signed-off-by: Frank Li <Frank.Li@xxxxxxx> > --- > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > index 1331858add942..1b6ab9550cce9 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > @@ -560,6 +560,7 @@ pcie1: pcie@3400000 { > rcpm: power-controller@1ee2140 { > compatible = "fsl,ls1012a-rcpm", "fsl,qoriq-rcpm-2.1+"; > reg = <0x0 0x1ee2140 0x0 0x4>; > + #power-domain-cells = <0>; The thing is this h/w is not controlling power domains nor using the binding. So I think the fix here is either rename the node name or drop this schema check ($nodename). We really only do the latter if we want to only reference the power-domain.yaml schema from all specific power domain controller schemas. That's really only done if there's more than just #foo-cells defined by the schema which is not the case here. So we should probably rename the node to 'rcpm' or something. Seems like a step back, but there's really nothing generic to use here. Rob
