Re: [PATCH 3/3] arm64: dts: qcom: sm8550-qrd: add port mapping to speakers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 27/06/2024 14:20, Krzysztof Kozlowski wrote:
Add appropriate mappings of Soundwire ports of WSA8845 speaker.  This
solves second (south) speaker sound distortions when playing audio.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

---

Bindings:
https://lore.kernel.org/all/20240626-port-map-v1-3-bd8987d2b332@xxxxxxxxxx/

Can be applied independently, if bindings are fine.
---
  arch/arm64/boot/dts/qcom/sm8550-qrd.dts | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
index d27820fb5fc0..de40cb623c8c 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-qrd.dts
@@ -935,6 +935,7 @@ north_spkr: speaker@0,0 {
  		sound-name-prefix = "SpkrLeft";
  		vdd-1p8-supply = <&vreg_l15b_1p8>;
  		vdd-io-supply = <&vreg_l3g_1p2>;
+		qcom,port-mapping = <1 2 3 7 10 13>;
  	};
/* WSA8845, Speaker South */
@@ -948,6 +949,7 @@ south_spkr: speaker@0,1 {
  		sound-name-prefix = "SpkrRight";
  		vdd-1p8-supply = <&vreg_l15b_1p8>;
  		vdd-io-supply = <&vreg_l3g_1p2>;
+		qcom,port-mapping = <4 5 6 7 11 13>;
  	};
  };

At some point I got the exact same change, but I guess I was missing the WSA macro register
shift so this did nothing...

Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux