On 06/26, Alexandru Ardelean wrote: > On Wed, Jun 26, 2024 at 12:55 AM Marcelo Schmitt > <marcelo.schmitt@xxxxxxxxxx> wrote: > > > > Implement MOSI idle low and MOSI idle high to better support peripherals > > that request specific MOSI behavior. > > > > One minor nitpick. > Feel free to ignore, if there won't be a re-spin. > > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> > > --- > > drivers/spi/spi-axi-spi-engine.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > ... > > @@ -646,6 +651,9 @@ static int spi_engine_probe(struct platform_device *pdev) > > > > host->dev.of_node = pdev->dev.of_node; > > host->mode_bits = SPI_CPOL | SPI_CPHA | SPI_3WIRE; > > + if (ADI_AXI_PCORE_VER_MAJOR(version) >= 1 && > > + ADI_AXI_PCORE_VER_MINOR(version) >= 3) > > + host->mode_bits |= SPI_MOSI_IDLE_LOW | SPI_MOSI_IDLE_HIGH; > > There's a second space after the assignment. > host->mode_bits |=<2 spaces here>SPI_MOSI_IDLE_LOW | > SPI_MOSI_IDLE_HIGH; ack thanks > > > > host->bits_per_word_mask = SPI_BPW_RANGE_MASK(1, 32); > > host->max_speed_hz = clk_get_rate(spi_engine->ref_clk) / 2; > > host->transfer_one_message = spi_engine_transfer_one_message; > > -- > > 2.43.0 > > > >
