Hi Andre,
On Tue, 25 Jun 2024, at 12:28 PM, Andre Przywara wrote:
Thanks for the review!
>> regmap_write(mixer->engine.regs, SUN50I_MIXER_CDC1_EN, 0);
>> - } else {
>> +
>
> That seems to add an extra line, which shouldn't be here.
This was intentional to add some whitespace between the block of register writes and the next if/then block, but happy to remove delete if that is the style preference.
>
> Verified that the rest is indeed just a code move, from below into a
> separate function. So with the two minor bits above fixed:
>
> Reviewed-by: Andre Przywara <andre.przywara@xxxxxxx>
>
Thanks again!
Ryan
