Hi, On Mon, Jun 24, 2024 at 7:21 AM Zhaoxiong Lv <lvzhaoxiong@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > +static int radxa_display_8hd_ad002_init_cmds(struct jadard *jadard) > +{ > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = jadard->dsi }; > + > + mipi_dsi_dcs_write_seq_multi(&dsi_ctx, 0xE0, 0x00); nit: could you convert the hex from UPPERCASE to lowercase in this patch. As an example, 0xE0 above should be 0xe0. Other than that nit, this looks OK to me: Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>