> -----Original Message----- > From: Jonathan Cameron <jic23@xxxxxxxxxx> > Sent: Sunday, June 23, 2024 9:44 PM > To: Conor Dooley <conor@xxxxxxxxxx> > Cc: Paller, Kim Seer <KimSeer.Paller@xxxxxxxxxx>; linux- > kernel@xxxxxxxxxxxxxxx; linux-iio@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; > David Lechner <dlechner@xxxxxxxxxxxx>; Lars-Peter Clausen > <lars@xxxxxxxxxx>; Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark Brown > <broonie@xxxxxxxxxx>; Dimitri Fedrau <dima.fedrau@xxxxxxxxx>; Krzysztof > Kozlowski <krzk+dt@xxxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>; Conor > Dooley <conor+dt@xxxxxxxxxx>; Hennerich, Michael > <Michael.Hennerich@xxxxxxxxxx>; Nuno Sá <noname.nuno@xxxxxxxxx> > Subject: Re: [PATCH v4 4/5] dt-bindings: iio: dac: Add adi,ltc2672.yaml > > [External] > > On Wed, 19 Jun 2024 18:57:59 +0100 > Conor Dooley <conor@xxxxxxxxxx> wrote: > > > On Wed, Jun 19, 2024 at 02:49:03PM +0800, Kim Seer Paller wrote: > > > +patternProperties: > > > + "^channel@[0-4]$": > > > + type: object > > > + additionalProperties: false > > > + > > > + properties: > > > + reg: > > > + description: The channel number representing the DAC output > channel. > > > + maximum: 4 > > > + > > > + adi,toggle-mode: > > > + description: > > > + Set the channel as a toggle enabled channel. Toggle operation > enables > > > + fast switching of a DAC output between two different DAC codes > without > > > + any SPI transaction. > > > + type: boolean > > > + > > > + adi,output-range-microamp: > > > + description: Specify the channel output full scale range. > > > + enum: [3125000, 6250000, 12500000, 25000000, 50000000, > 100000000, > > > + 200000000, 300000000] > > > > IIO folks, is this sort of thing common/likely to exist on other DACs? > > Fair point. It is probably time to conclude this is at least moderately common > and generalize it - which will need a dac.yaml similar to the one we have for > ADCs in adc/adc.yaml. That will need to make this a per channel node property > (same as the adc ones). Should I proceed with generalizing common DAC properties in this series and does this mean somehow removing these common properties from existing DAC bindings? > > I'd also expect it to always take 2 values. In many cases the first will be 0 but > that is fine. > > Jonathan
