On 6/19/24 00:45, Konrad Dybcio wrote:
On 6/18/24 16:56, Sibi Sankar wrote:
Add fastrpc nodes for ADSP and CDSP on X1E80100 SoC.
Signed-off-by: Sibi Sankar <quic_sibis@xxxxxxxxxxx>
Hey Konrad,
Thanks for taking time to review the series :)
---
[...]
+
+ compute-cb@1 {
+ compatible = "qcom,fastrpc-compute-cb";
+ reg = <1>;
+ iommus = <&apps_smmu 0x0c01 0x20>,
+ <&apps_smmu 0x0c21 0x20>;
(0x0c01 & ~0x20) == (0x0c21 & ~0x20), is this repetition required by
the firmware, or would it work with the latter entry dropped? (and
all others in this cdsp fastrpc list)
Yes the latter can/should be dropped. Thanks for catching this. Will
fix this in the next re-spin.
-Sibi
Konrad
