Re: [PATCH v2] arm64: dts: ti: k3-j722s-evm: Enable analog audio support

[Jayesh Choudhary <j-choudhary@xxxxxx>]

Hello Vignesh,

On 22/06/24 12:06, Vignesh Raghavendra wrote:
> On 12/06/24 10:42, Jayesh Choudhary wrote:
> [...]
> > diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> > index bf3c246d13d1..426ae3e8a839 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> > +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> > @@ -105,6 +105,16 @@ vdd_sd_dv: regulator-TLV71033 {
> >   			 <3300000 0x1>;
> >   	};
> >   
> > +	vcc_3v3_aud: regulator-vcc3v3 {
> > +		/* Output of LM5140 */
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "vcc_3v3";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		regulator-always-on;
> > +		regulator-boot-on;
> > +	};
> > +
> >   	vsys_io_1v8: regulator-vsys-io-1v8 {
> >   		compatible = "regulator-fixed";
> >   		regulator-name = "vsys_io_1v8";
> > @@ -122,6 +132,35 @@ vsys_io_1v2: regulator-vsys-io-1v2 {
> >   		regulator-always-on;
> >   		regulator-boot-on;
> >   	};
> > +
> > +	codec_audio: sound {
> > +		compatible = "simple-audio-card";
> > +		simple-audio-card,name = "J722S-EVM";
> > +		simple-audio-card,widgets =
> > +			"Headphone",	"Headphone Jack",
> > +			"Line",		"Line In",
> > +			"Microphone",	"Microphone Jack";
> > +		simple-audio-card,routing =
> > +			"Headphone Jack",	"HPLOUT",
> > +			"Headphone Jack",	"HPROUT",
> > +			"LINE1L",		"Line In",
> > +			"LINE1R",		"Line In",
> > +			"MIC3R",		"Microphone Jack",
> > +			"Microphone Jack",	"Mic Bias";
> > +		simple-audio-card,format = "dsp_b";
> > +		simple-audio-card,bitclock-master = <&sound_master>;
> > +		simple-audio-card,frame-master = <&sound_master>;
> > +		simple-audio-card,bitclock-inversion;
> > +
> > +		simple-audio-card,cpu {
> > +			sound-dai = <&mcasp1>;
> > +		};
> > +
> > +		sound_master: simple-audio-card,codec {
> > +			sound-dai = <&tlv320aic3106>;
> > +			clocks = <&audio_refclk1>;
> > +		};
> > +	};
> >   };
> >   
> >   &main_pmx0 {
>
> [...]
>
> > +&main_conf {
> > +	audio_refclk1: clock@82e4 {
> > +		compatible = "ti,am62-audio-refclk";
> > +		reg = <0x82e4 0x4>;
> > +		clocks = <&k3_clks 157 18>;
> > +		assigned-clocks = <&k3_clks 157 18>;
> > +		assigned-clock-parents = <&k3_clks 157 33>;
> > +		#clock-cells = <0>;
> > +	};
>
>
> Shouldn't this be in a SoC level dtsi? If the clock selection is based
> on board design, the only move the assigned-clocks* to board file and
> keep the rest in SoC level files.

Ok.
I will need to rebase on top of Siddharth's patches[0] which I see are
now merged.
Will do that and roll v3.

[0]: 
https://lore.kernel.org/all/20240615081600.3602462-4-s-vadapalli@xxxxxx/

Thanks,
Jayesh

> > +};