Re: [PATCH 2/2] riscv: dts: starfive: enable heartbeat LED for Milk-V Mars

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 6/21/24 10:02, FUKAUMI Naoki wrote:
Hi,

On 6/21/24 08:13, Heinrich Schuchardt wrote:
On 6/13/24 04:48, FUKAUMI Naoki wrote:
Milk-V Mars has a green LED to show system load. This patch enables
a green LED as a heartbeat LED.

Signed-off-by: FUKAUMI Naoki <naoki@xxxxxxxx>
---
  arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts | 13 +++++++++++++
  1 file changed, 13 insertions(+)

diff --git a/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts b/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
index fa0eac78e0ba..4f4bbf64dbe4 100644
--- a/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
+++ b/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
@@ -4,11 +4,24 @@
   */
  /dts-v1/;
+#include <dt-bindings/gpio/gpio.h>
+#include <dt-bindings/leds/common.h>
  #include "jh7110-common.dtsi"
  / {
      model = "Milk-V Mars";
      compatible = "milkv,mars", "starfive,jh7110";
+
+    leds {
+        compatible = "gpio-leds";
+
+        led-0 {
+            gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>;
+            color = <LED_COLOR_ID_GREEN>;
+            linux,default-trigger = "heartbeat";
+            function = LED_FUNCTION_HEARTBEAT;

According to the schematics the StarFive VisionFive 2 board like the Mars board has RGPIO3 connected to a green LED to display the power status. Shouldn't we consider both boards?

I think LED usage is vendor/board specific.

do I need to do something for VF2 to merge my patch?

--
FUKAUMI Naoki
Shenzhen MilkV Technology Co., Ltd.

Best regards,

--
FUKAUMI Naoki
Shenzhen MilkV Technology Co., Ltd.

Best regards

Heinrich

+        };
+    };
  };
  &gmac0 {






[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux