On Sun, Jun 23, 2024 at 12:48:53PM GMT, Barnabás Czémán wrote: > On Sun, Jun 23, 2024 at 7:59 AM Dmitry Baryshkov > <dmitry.baryshkov@xxxxxxxxxx> wrote: > > > > On Sun, Jun 23, 2024 at 01:25:52AM GMT, Barnabás Czémán wrote: > > > From: Daniil Titov <daniilt971@xxxxxxxxx> > > > > > > Add the mdp5_cfg_hw entry for MDP5 version v1.14 found on msm8937. > > > > > > Signed-off-by: Daniil Titov <daniilt971@xxxxxxxxx> > > > Signed-off-by: Barnabás Czémán <trabarni@xxxxxxxxx> > > > --- > > > drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c | 89 ++++++++++++++++++++++++++++++++ > > > 1 file changed, 89 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c > > > index c5179e4c393c..6413c0d3e237 100644 > > > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c > > > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_cfg.c > > > @@ -1011,6 +1011,94 @@ static const struct mdp5_cfg_hw msm8917_config = { > > > .max_clk = 320000000, > > > }; > > > > > > +static const struct mdp5_cfg_hw msm8937_config = { > > > + .name = "msm8937", > > > + .mdp = { > > > + .count = 1, > > > + .caps = MDP_CAP_CDM | > > > + MDP_CAP_SRC_SPLIT, > > > > Could you please point out the SRC_SPLIT reference? > Is this would be qcom,mdss-has-source-split in downstream, because if Yes, IIRC. > it is i think it is a mistake and it is wrong at msm8953 also. Please send a fix. > > > > Other than that LGTM > > > > -- > > With best wishes > > Dmitry -- With best wishes Dmitry