On Sun, Jun 23, 2024 at 07:17:07AM GMT, Keith Zhao wrote:
> >
> > On Tue, May 21, 2024 at 06:58:13PM +0800, keith wrote:
> > > add plane funs and helper funs
> > > add vs drm common struct and funs
> > >
> > > Signed-off-by: keith <keith.zhao@xxxxxxxxxxxxxxxx>
> > > ---
> > > drivers/gpu/drm/verisilicon/Makefile | 3 +-
> > > drivers/gpu/drm/verisilicon/vs_drv.h | 93 +++++
> > > drivers/gpu/drm/verisilicon/vs_plane.c | 487
> > > +++++++++++++++++++++++++ drivers/gpu/drm/verisilicon/vs_plane.h |
> > > 26 ++
> > > 4 files changed, 608 insertions(+), 1 deletion(-) create mode 100644
> > > drivers/gpu/drm/verisilicon/vs_drv.h
> > > create mode 100644 drivers/gpu/drm/verisilicon/vs_plane.c
> > > create mode 100644 drivers/gpu/drm/verisilicon/vs_plane.h
> > > +
> > > +/*@pitch_alignment: buffer pitch alignment required by sub-devices.*/
> >
> > Is that all the docs you want to add?
> It should delete the redundant parts which is unused,
> To make this patch clearer to review
I'm sorry, I can't understand your comment.
> >
> > > +struct vs_drm_device {
> > > + struct drm_device base;
> > > + unsigned int pitch_alignment;
> > > + /* clocks */
> > > + unsigned int clk_count;
> > > + struct clk_bulk_data *clks;
> > > + struct reset_control *rsts;
> > > + struct vs_dc dc;
> > > + int irq;
> >
> > As usual, please drop unused fields and add them when required.
>
> In principle, I try to split the patch independently according to this.
> In fact, there is still a lot of room for optimization
> The subsequent patches will maintain independence and remove redundant parts for decoupling
Yes, please.
--
With best wishes
Dmitry
