On Fri, Jun 21, 2024 at 01:26:31PM +0200, Kamil Horák (2N) wrote: > Add the definitions of LRE registers for Broadcom BCM5481x PHY > > Signed-off-by: Kamil Horák (2N) <kamilh@xxxxxxxx> > Reviewed-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> > --- > include/linux/brcmphy.h | 89 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 89 insertions(+) > > diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h > index 1394ba302367..ae39c33e4086 100644 > --- a/include/linux/brcmphy.h > +++ b/include/linux/brcmphy.h > @@ -270,6 +270,86 @@ > #define BCM5482_SSD_SGMII_SLAVE 0x15 /* SGMII Slave Register */ > #define BCM5482_SSD_SGMII_SLAVE_EN 0x0002 /* Slave mode enable */ > #define BCM5482_SSD_SGMII_SLAVE_AD 0x0001 /* Slave auto-detection */ > +#define BCM5482_SSD_SGMII_SLAVE_AD 0x0001 /* Slave auto-detection */ That looks odd. Is there something subtle i'm not seeing here? Andrew