Hi, On Sun, Jun 23, 2024 at 12:36 AM Rob Herring (Arm) <robh@xxxxxxxxxx> wrote: > > > On Sat, 22 Jun 2024 23:07:29 +0800, Chen-Yu Tsai wrote: > > From: Samuel Holland <samuel@xxxxxxxxxxxx> > > > > Some sunxi SoCs have in-package regulators controlled by a register in > > the system control MMIO block. Allow a child node for this regulator > > device in addition to SRAM child nodes. > > > > Signed-off-by: Samuel Holland <samuel@xxxxxxxxxxxx> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Signed-off-by: Chen-Yu Tsai <wens@xxxxxxxx> > > --- > > .../allwinner,sun4i-a10-system-control.yaml | 28 +++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.example.dtb: syscon@3000000: regulators@3000150: False schema does not allow {'compatible': ['allwinner,sun20i-d1-system-ldos'], 'reg': [[50331984, 4]], 'ldoa': {'regulator-min-microvolt': [[1800000]], 'regulator-max-microvolt': [[1800000]]}, 'ldob': {'regulator-name': ['vcc-dram'], 'regulator-min-microvolt': [[1500000]], 'regulator-max-microvolt': [[1500000]]}} > from schema $id: http://devicetree.org/schemas/sram/allwinner,sun4i-a10-system-control.yaml# > Documentation/devicetree/bindings/sram/allwinner,sun4i-a10-system-control.example.dtb: /example-1/syscon@3000000/regulators@3000150: failed to match any schema with compatible: ['allwinner,sun20i-d1-system-ldos'] I'm not seeing this error locally. The binding in question for 'allwinner,sun20i-d1-system-ldos' was merged in v6.10-rc1 in commit 622bab188484 ("regulator: dt-bindings: Add Allwinner D1 system LDOs"). ChenYu > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240622150731.1105901-2-wens@xxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >