> On 22 Jun 2024, at 5:03 PM, Mark Brown <broonie@xxxxxxxxxx> wrote: > > On Sat, Jun 22, 2024 at 12:46:03PM +0000, Christian Hewitt wrote: >> Add a compatible string to enable support for the ti,pcm5242 DAC chip >> in the pcm512x driver. >> >> Signed-off-by: Christian Hewitt <christianshewitt@xxxxxxxxx> >> --- >> sound/soc/codecs/pcm512x-i2c.c | 2 ++ >> 1 file changed, 2 insertions(+) > > The device appears to have SPI support too like the other devices in the > family, why not add the ID for SPI as well: > > https://www.ti.com/product/PCM5242 Okay, will do. I need to send v2 anyway as I fat-fingered the chip number in the bindings patch subject/description :( Christian
