Re: [PATCH v2 2/5] dt-bindings: mfd: rk817: Merge support for RK809

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 22, 2024 at 12:57:19AM +0300, Cristian Ciocaltea wrote:
> The Rockchip RK809 PMIC is compatible with RK817 and provides the same
> capabilities, except for the battery charger manager.
> 
> There are also minor regulator related differences: BOOST and OTG_SWITCH
> are specific to RK817, while DCDC_REG5, SWITCH_REG1 and SWITCH_REG2 are
> provided RK809.
> 
> The current binding for RK809 doesn't document the audio codec
> properties, although it has been already in use by several boards:
> rk3566-quartz64-b, k3566-roc-pc, rk3568-evb1-v10, rk3568-lubancat-2,
> rk3568-odroid-m1, rk3568-rock-3a.
> 
> Therefore dtbs_check fails for all of them:
> 
>   DTC_CHK arch/arm64/boot/dts/rockchip/rk3568-rock-3a.dtb
>   rk3568-rock-3a.dtb: pmic@20: '#sound-dai-cells', 'assigned-clock-parents', 'assigned-clocks', 'clock-names', 'clocks', 'codec' do not match any of the regexes: 'pinctrl-[0-9]+'
>     from schema $id: http://devicetree.org/schemas/mfd/rockchip,rk809.yaml#
> 

> Additionally, the example in rockchip,rk809 binding is not able to
> actually test the schema since it uses a wrong compatible
> 'rockchip,rk808' instead of the expected 'rockchip,rk809'.

lol

> 
> Instead of duplicating even more content, merge the RK809 support into
> the more inclusive RK817 schema and drop the now obsolete rockchip,rk809
> related file.
> 
> Fixes: 6c38ca03406e ("dt-bindings: mfd: rk808: Convert bindings to yaml")
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>

Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux