On Sat, Jun 22, 2024 at 01:56:42PM +0800, Yasin Lee wrote: > > On 2024/6/21 18:12, Krzysztof Kozlowski wrote: > > Hi ,Krzysztof > Thank you for your reply. I have some questions inline. > > Best regards, > Yasin > > > On 21/06/2024 09:40, Yasin Lee wrote: > > > A capacitive proximity sensor > > > > > > Signed-off-by: Yasin Lee <yasin.lee.x@xxxxxxxxx> > > > --- > > > .../bindings/iio/proximity/tyhx,hx9023s.yaml | 115 +++++++++++++++++++++ > > > 1 file changed, 115 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml b/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml > > > new file mode 100644 > > > index 000000000000..beca70ce7609 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/iio/proximity/tyhx,hx9023s.yaml > > > @@ -0,0 +1,115 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/iio/proximity/tyhx,hx9023s.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: TYHX HX9023S capacitive proximity sensor > > > + > > > +maintainers: > > > + - Yasin Lee <yasin.lee.x@xxxxxxxxx> > > > + > > > +description: | > > > + TYHX HX9023S proximity sensor. Datasheet can be found here: > > > + http://www.tianyihexin.com/ueditor/php/upload/file/20240614/1718336303992081.pdf > > > + > > > +allOf: > > > + - $ref: /schemas/iio/iio.yaml# > > Which part of iio.yaml binding do you use here? I cannot find anything, > > so this looks wrong. > > > > I will remove this reference. > > > > > + > > > +properties: > > > + compatible: > > > + const: tyhx,hx9023s > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + interrupts: > > > + description: > > > + Generated by device to announce preceding read request has finished > > > + and data is available or that a close/far proximity event has happened. > > > + maxItems: 1 > > > + > > > + vdd-supply: true > > > + > > > + "#address-cells": > > > + const: 1 > > > + > > > + "#size-cells": > > > + const: 0 > > > + > > > +patternProperties: > > > + "^channel@[0-4]$": > > > + $ref: /schemas/iio/adc/adc.yaml > > > + type: object > > > + > > > + properties: > > > + reg: > > > + minimum: 0 > > > + maximum: 4 > > > + description: The channel number. > > > + > > > + input-channel: > > Isn't this duplicating single-channel property? > > > > Where is this property defined (which common schema)? > > > |input-channel| is indeed intended for single-ended configuration, but I > couldn't find a definition > > or reference for |single-channel| anywhere. If possible, should I rename > |input-channel| to |single-channel|? Single-channel is new, it should be the next branch of the iio tree and in linux-next.
Attachment:
signature.asc
Description: PGP signature
