On Wed, 2015-03-04 at 11:34 +0300, Aleksei Mamlin wrote:
> This patch adds device tree support for 5-finger chips, like GT911
> and GT912.
You should add the same support to the ACPI matching.
<snip>
> #ifdef CONFIG_OF
> static struct of_device_id goodix_of_match[] = {
> - { .compatible = "goodix,gt9110" },
> - { .compatible = "goodix,gt927" },
> - { .compatible = "goodix,gt9271" },
> - { .compatible = "goodix,gt928" },
> - { .compatible = "goodix,gt967" },
> + { .compatible = "goodix,gt911", .data = (void *) 5 },
> + { .compatible = "goodix,gt9110", .data = (void *) 10 },
There's no need to add "10" for these tablets as it's already the
GOODIX_MAX_CONTACTS value. Or you need to add it to every instance.
I would also like a link to the spec sheets in the commit message.
> + { .compatible = "goodix,gt912", .data = (void *) 5 },
> + { .compatible = "goodix,gt927", .data = (void *) 10 },
> + { .compatible = "goodix,gt9271", .data = (void *) 10 },
> + { .compatible = "goodix,gt928", .data = (void *) 10 },
> + { .compatible = "goodix,gt967", .data = (void *) 10 },
> { }
> };
> MODULE_DEVICE_TABLE(of, goodix_of_match);
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
