Am 20.06.2024 um 20:42 schrieb Heiko Stübner:
Am Mittwoch, 12. Juni 2024, 22:48:12 CEST schrieb Sebastian Kropatsch:
DT validation doesn't like the 'linux,default-trigger = "stmmac-0:01:link"'
properties, since "*:link" is not a valid value according to
[Documentation/devicetree/bindings/leds/common.yaml]. These LEDs do
have the specific purpose to show if an Ethernet link is up though.
There is one LED for each Ethernet port and they are labeled WAN and
LAN.
Using the 'linux,default-trigger' like this does work perfectly fine
with this solution. I could not find another way to achieve this. Please
let me know if there is a better way.
Maybe it would also be valid to add an entry to the DT bindings file to
allow "*:link" as a value for 'linux,default-trigger'?
correct. If needed, things should be added to binding.
Alright, I'll add this to the binding at
[Documentation/devicetree/bindings/leds/common.yaml]
Should this be a completely separate patch or is it preferred
to add a patch to this NanoPi patch series?
Cheers,
Sebastian
