Thanks for the review Maxime, On 3 March 2015 at 08:13, Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > Hi, > > On Sat, Feb 28, 2015 at 02:43:24PM +0100, codekipper@xxxxxxxxx wrote: >> From: Marcus Cooper <codekipper@xxxxxxxxx> >> >> The MK808C is an A20 based android stick, with 1G RAM, 8G NAND flash, >> a RTL8723au wifi + bt combo chip, a USB host ports using USB-A receptacles, >> a mini USB-B receptacle for USB OTG, mini HDMI and a TRS connector for AV. >> >> This patch adds basic support for the device, more information can be found >> here (http://linux-sunxi.org/MK808C). >> >> Signed-off-by: Marcus Cooper <codekipper@xxxxxxxxx> >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/sun7i-a20-mk808c.dts | 146 +++++++++++++++++++++++++++++++++ >> 2 files changed, 147 insertions(+) >> create mode 100644 arch/arm/boot/dts/sun7i-a20-mk808c.dts >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index 9544768..eae7706 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -542,6 +542,7 @@ dtb-$(CONFIG_MACH_SUN7I) += \ >> sun7i-a20-hummingbird.dtb \ >> sun7i-a20-i12-tvbox.dtb \ >> sun7i-a20-m3.dtb \ >> + sun7i-a20-mk808c.dtb \ >> sun7i-a20-olinuxino-lime.dtb \ >> sun7i-a20-olinuxino-lime2.dtb \ >> sun7i-a20-olinuxino-micro.dtb \ >> diff --git a/arch/arm/boot/dts/sun7i-a20-mk808c.dts b/arch/arm/boot/dts/sun7i-a20-mk808c.dts >> new file mode 100644 >> index 0000000..5722a03 >> --- /dev/null >> +++ b/arch/arm/boot/dts/sun7i-a20-mk808c.dts >> @@ -0,0 +1,146 @@ >> +/* >> + * Copyright 2015 Marcus Cooper >> + * >> + * Marcus Cooper <codekipper@xxxxxxxxx> >> + * >> + * This file is dual-licensed: you can use it either under the terms >> + * of the GPL or the X11 license, at your option. Note that this dual >> + * licensing only applies to this file, and not this project as a >> + * whole. >> + * >> + * a) This file is free software; you can redistribute it and/or >> + * modify it under the terms of the GNU General Public License as >> + * published by the Free Software Foundation; either version 2 of the >> + * License, or (at your option) any later version. >> + * >> + * This file is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public >> + * License along with this file; if not, write to the Free >> + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, >> + * MA 02110-1301 USA >> + * >> + * Or, alternatively, >> + * >> + * b) Permission is hereby granted, free of charge, to any person >> + * obtaining a copy of this software and associated documentation >> + * files (the "Software"), to deal in the Software without >> + * restriction, including without limitation the rights to use, >> + * copy, modify, merge, publish, distribute, sublicense, and/or >> + * sell copies of the Software, and to permit persons to whom the >> + * Software is furnished to do so, subject to the following >> + * conditions: >> + * >> + * The above copyright notice and this permission notice shall be >> + * included in all copies or substantial portions of the Software. >> + * >> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, >> + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES >> + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND >> + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT >> + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, >> + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING >> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR >> + * OTHER DEALINGS IN THE SOFTWARE. >> + */ >> + >> +/dts-v1/; >> +#include "sun7i-a20.dtsi" >> +#include "sunxi-common-regulators.dtsi" >> + >> +#include <dt-bindings/gpio/gpio.h> >> +#include <dt-bindings/interrupt-controller/irq.h> >> +#include <dt-bindings/pinctrl/sun4i-a10.h> > > You don't seem to be using the pinctrl header. > I'll remove this.... >> + >> +/ { >> + model = "mk808c"; >> + compatible = "mk808c", "allwinner,sun7i-a20"; > > the compatible must be of the format "vendor,device". Please add the > vendor name. Ahhh....I've searched high and low for a vendors name. I listed it as unknown on the wiki page, would 'odm' be considered valid? CK > > Maxime > > -- > Maxime Ripard, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
