Re: [PATCH v9 3/7] coresight: core: Add provision for panic callbacks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2024-06-05 at 21:39:17, James Clark (james.clark@xxxxxxx) wrote:
> 
> 
> On 05/06/2024 09:17, Linu Cherian wrote:
> > Panic callback handlers allows coresight device drivers to sync
> > relevant trace data and trace metadata to reserved memory
> > regions so that they can be retrieved later in the subsequent
> > boot or in the crashdump kernel.
> > 
> > Signed-off-by: Linu Cherian <lcherian@xxxxxxxxxxx>
> > Reviewed-by: James Clark <james.clark@xxxxxxx>
> > ---
> > Changelog from v8:
> > Added Reviewed-by tag.
> > 
> >  drivers/hwtracing/coresight/coresight-core.c | 37 ++++++++++++++++++++
> >  include/linux/coresight.h                    | 12 +++++++
> >  2 files changed, 49 insertions(+)
> > 
> 
> [...]
> 
> >  static int __init coresight_init(void)
> >  {
> >  	int ret;
> > @@ -1377,6 +1408,10 @@ static int __init coresight_init(void)
> >  	if (ret)
> >  		goto exit_bus_unregister;
> >  
> > +	/* Register function to be called for panic */
> > +	ret = atomic_notifier_chain_register(&panic_notifier_list,
> > +					     &coresight_notifier);
> > +
> 
> ret isn't checked here

Ack.

> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux