On 6/19/24 12:27 PM, Marcelo Schmitt wrote: > On 06/19, David Lechner wrote: >> On 6/18/24 6:11 PM, Marcelo Schmitt wrote: >>> @@ -646,6 +651,9 @@ static int spi_engine_probe(struct platform_device *pdev) >>> >>> host->dev.of_node = pdev->dev.of_node; >>> host->mode_bits = SPI_CPOL | SPI_CPHA | SPI_3WIRE; >>> + if (ADI_AXI_PCORE_VER_MAJOR(version) >= 1 && >> >> Currently, the major version is required to be 1, so this check is not >> strictly needed. >> > This is expecting the MOSI idle feature to be available on all versions from 1.3 on. > Will SPI-Engine always be major version 1? <yoda voice>Difficult to see, the future is.</yoda voice> It's fine if you want to leave it the way it is. > >>> + ADI_AXI_PCORE_VER_MINOR(version) >= 3) >>> + host->mode_bits |= SPI_MOSI_IDLE_LOW | SPI_MOSI_IDLE_HIGH; >>
