On 17/06/2024 19:14, Jeffrey Hugo wrote: > On 6/15/2024 5:35 AM, Konrad Dybcio wrote: >> On 14.06.2024 12:33 PM, Dmitry Baryshkov wrote: >>> On Fri, Jun 14, 2024 at 01:55:46AM GMT, Konrad Dybcio wrote: >>>> >>>> >> >> [...] >> >>>> GCC_HDMI_CLKREF_CLK is a child of xo, so you can drop the latter. >>>> It would also be worth confirming whether it's really powering the >>>> PHY and not the TX.. You can test that by trying to only power on the >>>> phy (e.g. call the phy_power_on or whatever APIs) with and without the >>>> clock >>> >>> I'd prefer to keep it. I think the original DT used one of LN_BB clocks >>> here, so it might be that the HDMI uses CXO2 / LN_BB instead of the main >>> CXO. >>> >>> If somebody can check, which clock is actually used for the HDMI, it >>> would be really great. >> >> +CC jhugo - could you please take a look? >> >> Konrad > > Documentation is not great but it looks like CXO from what little I can > find. If I read correctly, the conclusion of this sub-thread is that the clock tree described in the patch is correct? HDMI controller: + clocks = <&mmcc MDSS_MDP_CLK>, + <&mmcc MDSS_AHB_CLK>, + <&mmcc MDSS_HDMI_CLK>, + <&mmcc MDSS_HDMI_DP_AHB_CLK>, + <&mmcc MDSS_EXTPCLK_CLK>, + <&mmcc MDSS_AXI_CLK>, + <&mmcc MNOC_AHB_CLK>, + <&mmcc MISC_AHB_CLK>; + clock-names = + "mdp_core", + "iface", + "core", + "alt_iface", + "extp", + "bus", + "mnoc", + "iface_mmss"; PHY: + clocks = <&mmcc MDSS_AHB_CLK>, + <&gcc GCC_HDMI_CLKREF_CLK>, + <&rpmcc RPM_SMD_XO_CLK_SRC>; + clock-names = "iface", + "ref", + "xo"; Regards
