On Mon, Jun 17, 2024 at 05:45:16PM +0200, Christophe Roullier wrote:
> Add Ethernet support for STM32MP25.
> STM32MP25 is STM32 SOC with 2 GMACs instances.
> GMAC IP version is SNPS 5.3x.
> GMAC IP configure with 2 RX and 4 TX queue.
> DMA HW capability register supported
> RX Checksum Offload Engine supported
> TX Checksum insertion supported
> Wake-Up On Lan supported
> TSO supported
>
> Signed-off-by: Christophe Roullier <christophe.roullier@xxxxxxxxxxx>
The nit below notwithstanding, this looks good to me,
and appears to address review of earlier versions.
Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
> ---
> .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 77 ++++++++++++++++++-
> 1 file changed, 74 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c
...
> @@ -365,6 +423,9 @@ static int stm32_dwmac_parse_data(struct stm32_dwmac *dwmac,
> return err;
> }
>
> + if (dwmac->ops->is_mp2)
> + return err;
> +
nit: As far as I understand things, the intention here is to return early,
rather than to return an error. And err will always be 0.
So it might be clearer to simply:
return 0;
> dwmac->mode_mask = SYSCFG_MP1_ETH_MASK;
> err = of_property_read_u32_index(np, "st,syscon", 2, &dwmac->mode_mask);
> if (err) {
...
