… > +++ b/drivers/hwtracing/coresight/coresight-csr.c > @@ -0,0 +1,315 @@ … > +static int __csr_set_etr_traceid(struct coresight_device *csdev, > + uint32_t atid_offset, uint32_t traceid, > + bool enable) > +{ … > + spin_lock_irqsave(&drvdata->spin_lock, flags); > + CS_UNLOCK(drvdata->base); … > + CS_LOCK(drvdata->base); > + spin_unlock_irqrestore(&drvdata->spin_lock, flags); > + return 0; > +} … Would you become interested to apply a statement like “guard(spinlock_irqsave)(&drvdata->spin_lock);”? https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/spinlock.h#L574 Regards, Markus