Hi Conor, On Tue, Jun 18, 2024 at 06:43:18PM +0100, Conor Dooley wrote: > On Tue, Jun 18, 2024 at 04:44:54PM +0800, Charles Wang wrote: > > The Goodix GT7986U touch controller report touch data according to the > > HID protocol through the SPI bus. However, it is incompatible with > > Microsoft's HID-over-SPI protocol. > > > > Signed-off-by: Charles Wang <charles.goodix@xxxxxxxxx> > > --- > > .../bindings/input/goodix,gt7986u.yaml | 72 +++++++++++++++++++ > > 1 file changed, 72 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > > > > diff --git a/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > > new file mode 100644 > > index 000000000..25a26b4ce > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > > @@ -0,0 +1,72 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/input/goodix,gt7986u.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: GOODIX GT7986U SPI HID Touchscreen > > + > > +maintainers: > > + - Charles Wang <charles.goodix@xxxxxxxxx> > > + > > +description: Supports the Goodix GT7986U touchscreen. > > + This touch controller reports data packaged according to the HID protocol, > > + but is incompatible with Microsoft's HID-over-SPI protocol. > > + > > +allOf: > > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - goodix,gt7986u > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + reset-gpios: > > + maxItems: 1 > > + description: reset gpio the chip is connected to. > > The description here isn't needed, it's obvious :) > Ack. > > + goodix,hid-report-addr: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + description: | > > This | is not needed, there's no formatting to preserve. > > Those are nits: > Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > Thank you. If there is a next version, I will fix these. Charles, > > > + The register address for retrieving HID report data. > > + This address is related to the device firmware and may > > + change after a firmware update. > > + > > + spi-max-frequency: true > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - reset-gpios > > + - goodix,hid-report-addr > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + #include <dt-bindings/gpio/gpio.h> > > + > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + touchscreen@0 { > > + compatible = "goodix,gt7986u"; > > + reg = <0>; > > + interrupt-parent = <&gpio>; > > + interrupts = <25 IRQ_TYPE_LEVEL_LOW>; > > + reset-gpios = <&gpio1 1 GPIO_ACTIVE_LOW>; > > + spi-max-frequency = <10000000>; > > + goodix,hid-report-addr = <0x22c8c>; > > + }; > > + }; > > + > > +... > > -- > > 2.43.0 > >
