On Tue, Jun 18, 2024 at 11:48:26PM +0800, Yangyu Chen wrote: > > > On Jun 18, 2024, at 23:40, Conor Dooley <conor@xxxxxxxxxx> wrote: > > > > On Mon, Jun 17, 2024 at 01:20:49AM +0800, Yangyu Chen wrote: > >> Add compatible string for SpacemiT K1 CLINT. > >> > >> Signed-off-by: Yangyu Chen <cyy@xxxxxxxxxxxx> > > > > Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > Actually, I'm not confident about this after carefully reviewing > the file. The "riscv,clint0" is marked deprecated, and the description > is For the QEMU virtual machine only. Right, I forgot about that portion of it. Probably, if this is sifive plic compatible, then fall back to the sifive clint. Same, I suppose, goes for the plic etc. The alternative is not have a fallback, modify the driver, and future spacemit things will fall back to the k1's compatible. I don't mind which you go for.
Attachment:
signature.asc
Description: PGP signature
