On Mon, Jun 17, 2024 at 02:01:02PM -0500, Paul Handrigan wrote: > +static bool cs530x_volatile_register(struct device *dev, unsigned int reg) > +{ > + switch (reg) { > + case CS530X_DEVID: > + case CS530X_REVID: > + return true; > + default: > + return false; > + } > +} Are these really volatile? I would expect them to have no defaults so they must be read from the device, but once read I'd expect we could cache the values. Otherwise this looks good.
Attachment:
signature.asc
Description: PGP signature