On Fri, Jun 14, 2024 at 04:26:22PM +0100, Conor Dooley wrote: > On Fri, Jun 14, 2024 at 08:15:38PM +0800, Charles Wang wrote: > > The Goodix GT7986U touch controller report touch data according to the > > HID protocol through the SPI bus. However, it is incompatible with > > Microsoft's HID-over-SPI protocol. > > > > Signed-off-by: Charles Wang <charles.goodix@xxxxxxxxx> > > --- > > .../bindings/input/goodix,gt7986u.yaml | 65 +++++++++++++++++++ > > 1 file changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > > > > diff --git a/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > > new file mode 100644 > > index 000000000..1c518d03b > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/input/goodix,gt7986u.yaml > > @@ -0,0 +1,65 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/input/goodix,gt7986u.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: GOODIX GT7986U SPI HID Touchscreen > > + > > +maintainers: > > + - Charles Wang <charles.goodix@xxxxxxxxx> > > + > > +description: > > + Supports the Goodix GT7986U touchscreen. > > + This touch controller reports data packaged according to the HID protocol, > > + but is incompatible with Microsoft's HID-over-SPI protocol. > > + > > +allOf: > > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > > + > > +properties: > > + compatible: > > + enum: > > + - goodix,gt7986u > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + maxItems: 1 > > + > > + reset-gpios: > > + maxItems: 1 > > + description: reset gpio the chip is connected to. > > + > > + goodix,hid-report-addr: > > + description: the register address for retrieving HID report data. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + > > +additionalProperties: false > > unevaluatedProperties: false. > > Please test your binding w/ dt_binding_check. > Ack. I have tested it using "make dt_binding_check" and there were no errors or warnings output. :( Additionally, I have already run "pip3 install dtschema --upgrade". > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - goodix,hid-report-addr > > + > > +examples: > > + - | > > + #include <dt-bindings/interrupt-controller/irq.h> > > + #include <dt-bindings/gpio/gpio.h> > > + spi { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + num-cs = <1>; > > + cs-gpios = <&gpio 2 GPIO_ACTIVE_HIGH>; > > cs-gpios shouldn't be needed for a basic example. > > Blank line here before the child node please. > Ack Charles Thanks
