Hi, On Mon, Jun 17, 2024 at 03:17:50PM GMT, Alexey Charkov wrote: > On Mon, Jun 17, 2024 at 2:58 PM Jacobe Zang <jacobe.zang@xxxxxxxxxx> wrote: > > > > >I'm also wondering why would adding a DT node for a PCI device be needed > > >in the first place, given that PCI supports device discovery? > > > > In fact, I learn that PCIe bus devices do not need compatible to probe just now... Before sending this patch, I committed the code that added "pci14e4,449d" to vendor-prefix.yaml and net/wireless/brcm,brcm4329-fmac.yaml. Now I know the reason why my addition was rejected. By the way, except for the compatible binding, is there any other binding that I should remove?? > > If your PCI bridge is functioning properly and if your WiFi adapter is > connected and physically enabled (in terms of power and RFKILL) I > believe it should be automatically discovered and you should see it in > lspci. No additional DT nodes needed - but check if you need any > additional DT property somewhere to keep the HYM8563 clock enabled. > I'm not sure your pcie@0,0 node is needed either. > > Then it's up to the driver to recognize your adapter by its PCI ID and > attach. I guess you'd need to extend the hardware IDs table in the > brcmfmac driver for it to attach - similar to [1] > > [1] https://github.com/armbian/build/blob/main/patch/kernel/archive/rockchip-rk3588-6.10/0801-wireless-add-bcm43752.patch RK3588 EVB1 has the same WLAN/BT module and I started looking into adding support at a low priority. I think this is very similar to the Qualcomm chip Bartosz Golaszewski worked on and thus should get a pwrseq driver, which handles the enable GPIOs, regulators and clocks. If any of them are missing the PCIe device is not discovered. Note, that this will actually require describing the PCIe device in DT to reference the pwrseq device. Additionally the brcmfmac need to be extended to actually have working wlan. I put some links and notes about this here: https://gitlab.collabora.com/hardware-enablement/rockchip-3588/linux/-/issues/1 Greetings, -- Sebastian
Attachment:
signature.asc
Description: PGP signature
