Re: [PATCH 4/6] ARM: DT: STi: STiH407: Add dwc3 usb3 DT node.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Peter,

On 02/27/2015 11:43 AM, Peter Griffin wrote:
Hi Lee,

On Wed, 25 Feb 2015, Lee Jones wrote:

+			reset-names	= "powerdown",
+					  "softreset";
Nit: What's the purpose of having these on separate lines?
The only reason was to stay aligned with the example in
Documentation/devicetree/bindings/usb/dwc3-st.txt.
But didn't you author that too? :)
Yep

I would change them both.  No need to force a line wrap if it's not required.
Ok, I'll remove it from both in v2, whilst adding the acks.
Thanks. Once fixed, you can add my:
Acked-by: Maxime Coquelin <maxime.coquelin@xxxxxx>

BR,
Maxime

regards,

Peter.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux