FUKAUMI Naoki wrote:
> Milk-V Mars has a green LED to show system load. This patch enables
> a green LED as a heartbeat LED.
>
> Signed-off-by: FUKAUMI Naoki <naoki@xxxxxxxxx>
> ---
> arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts b/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
> index fa0eac78e0ba..4f4bbf64dbe4 100644
> --- a/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
> +++ b/arch/riscv/boot/dts/starfive/jh7110-milkv-mars.dts
> @@ -4,11 +4,24 @@
> */
>
> /dts-v1/;
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/leds/common.h>
> #include "jh7110-common.dtsi"
>
> / {
> model = "Milk-V Mars";
> compatible = "milkv,mars", "starfive,jh7110";
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + led-0 {
> + gpios = <&aongpio 3 GPIO_ACTIVE_HIGH>;
> + color = <LED_COLOR_ID_GREEN>;
> + linux,default-trigger = "heartbeat";
> + function = LED_FUNCTION_HEARTBEAT;
Hi Naoki,
Thank you for the patch! I know the JH7100 boards are a bad example but
normally we don't assign triggers/functions to LEDs unless they have a clearly
marked purpose on the board. Otherwise we'll let userspace assign their
function (usually with udev rules).
As far as I can tell this line is marked "STS_PWR" in the schematic, the LED
itself is just marked "Green", and the silkscreen doesn't seem to indicate that
this LED should be a heartbeat. So I'd prefer just describing the LED and let
it be up to users or pre-cooked images to assign the function.
/Emil
> + };
> + };
> };
>
> &gmac0 {
> --
> 2.43.0
>
