On Sat, Jun 15, 2024 at 12:01 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > Do not attach (thread) your patchsets to some other threads (unrelated > or older versions). This buries them deep in the mailbox and might > interfere with applying entire sets. I'm sorry about that, it won't happen again. > > + dma-vc-names: > > Missing vendor prefix... but I don't really get what's the point of this > property. Is "nxp,lpc3xxx-dma-vc-names" acceptable? > > > + $ref: /schemas/types.yaml#/definitions/string-array > > + description: | > > + names of virtual pl08x dma channels for tx and rx > > + directions in this order. > > + minItems: 2 > > + maxItems: 2 > > What part of hardware or board configuration this represents? > > It wasn't here and nothing in changelog explained it. That's information which DMA signal and mux setting an I2S interface uses. It's a name (bus_id field) of platform data entry from phy3250.c in [PATCH v3 3/4]. It's used by snd_soc_dai_init_dma_data() in [PATCH v3 4/4] to give the dmaengine a hint which dma config to use. The LPC32xx doesn't have yet a dmamux driver like lpc18xx-dmamux.c therefore it still uses platform data entries for pl08x dma channels and 'SND_DMAENGINE_PCM_FLAG_NO_DT | SND_DMAENGINE_PCM_FLAG_COMPAT' flags in the devm_snd_dmaengine_pcm_register(). Typically instead of this platform data you would use regular 'dma' and 'dma-names' if it had proper dmamux driver like lpc18xx-dmamux.c > > Drop. > > > > + > > + "#sound-dai-cells": > > + const: 0 > > + The "dai-common.yam" doesn't declare a default value for this so isn't it required? It's declared in others yaml files like: Documentation/devicetree/bindings/sound/qcom,q6apm.yaml -- Piotr Wojtaszczyk Timesys
