On 17/06/2024 02:30, Kuninori Morimoto wrote: > This patch add ak4619 DT binding Please do not use "This commit/patch/change", but imperative mood. See longer explanation here: https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95 Just "Add Asahi Kasei AK4619 audio codec bindings.". With the full stop. > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > --- > .../devicetree/bindings/sound/ak4619.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/ak4619.yaml Missing vendor prefix. Filenames use compatible syntax. > > diff --git a/Documentation/devicetree/bindings/sound/ak4619.yaml b/Documentation/devicetree/bindings/sound/ak4619.yaml > new file mode 100644 > index 0000000000000..b6afc008f745e > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/ak4619.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/ak4619.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: AK4619 I2C transmitter > + > +maintainers: > + - Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > + - Khanh Le <khanh.le.xr@xxxxxxxxxxx> > + > +allOf: > + - $ref: dai-common.yaml# > + > +properties: > + compatible: > + const: asahi-kasei,ak4619 > + > + reg: > + maxItems: 1 > + > + "#sound-dai-cells": > + const: 0 > + > + ports: > + $ref: audio-graph-port.yaml#/definitions/ports > + > + port: > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false Why do you have both ports and port? > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + ak4619: codec@10 { > + compatible = "asahi-kasei,ak4619"; > + reg = <0x10>; Make the example complete - include all properties. Best regards, Krzysztof
