On 14/06/2024 09:19, Claudiu wrote: > From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > + > +maintainers: > + - Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx> > + > +properties: > + compatible: > + items: > + - const: renesas,rzg3s-vbattb > + - const: syscon > + - const: simple-mfd No, mfd does no look good. That's not a simple device anymore and you claim here child does not need vbat bclk, power domains and resets? That would be a big surprise, although technically possible. Please clarify: which of parent resources are needed for children? ... > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/r9a08g045-cpg.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + > + vbattb: vbattb@1005c000 { > + compatible = "renesas,rzg3s-vbattb", "syscon", "simple-mfd"; > + reg = <0x1005c000 0x1000>; > + ranges = <0 0 0x1005c000 0 0x1000>; > + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "tampdi"; > + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>; > + clock-names = "bclk"; > + power-domains = <&cpg>; > + resets = <&cpg R9A08G045_VBAT_BRESETN>; > + #address-cells = <2>; > + #size-cells = <2>; > + status = "disabled"; Drop > + > + vbattclk: clock-controller@1c { > + compatible = "renesas,rzg3s-vbattb-clk"; > + reg = <0 0x1c 0 0x10>; > + clocks = <&cpg CPG_MOD R9A08G045_VBAT_BCLK>, <&vbattb_xtal>; > + clock-names = "bclk", "vbattb_xtal"; > + #clock-cells = <0>; > + power-domains = <&cpg>; > + status = "disabled"; Drop > + }; > + }; > + > +... Best regards, Krzysztof