Re: [PATCH v4 2/2] dt-bindings: iio: st-sensors: add LIS2DS12 accelerometer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 15 Jun 2024 13:11:04 +0100
Conor Dooley <conor@xxxxxxxxxx> wrote:

> On Sat, Jun 15, 2024 at 09:46:59AM +0000, Kaustabh Chakraborty wrote:
> > On 2024-06-11 18:17, Conor Dooley wrote:  
> > > On Tue, Jun 11, 2024 at 09:35:53PM +0530, Kaustabh Chakraborty wrote:  
> > >> Add compatible for LIS2DS12 accelerometer by STMicroelectronics.  
> > > 
> > > I can see that! Your commit message should mention why this device
> > > is not compatible with existing variants.  
> > 
> > Sure, is adding the WhoAmI value enough? Or do I also have to
> > explain the different registers and sensor settings.  
> 
> The whoami isn't sufficient, but if there's registers that behave
> differently etc, please mention those.
> 

Or (mostly putting this for future reference of anyone reading this)
undiscoverable things like different scale factors for channels.

> Thanks,
> Conor.





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux