Re: [PATCH 2/2] ASoC: cs530x: Support for cs530x ADCs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13/06/2024 19:55, Paul Handrigan wrote:
> On Mon, Jun 10, 2024 at 10:46:26AM +0200, Krzysztof Kozlowski wrote:
> 
>>> +
>>> +	if (cs530x->reset_gpio) {
>>> +		usleep_range(2000, 2100);
>>> +		gpiod_set_value_cansleep(cs530x->reset_gpio, 1);
>>
>> 1 is to keep device in reset? This looks like you are using logical
>> values inverted.
> Thanks.  The reset pin is active low. I will also change the dt binding
> example to reflect that.

The value here is logical from driver point of view, not wire level, so
you use wrong code.

If you tested it with real and correct DTS, you would see it does not work.

Best regards,
Krzysztof





[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux