On 13/06/2024 15:19, joswang wrote: > On Thu, Jun 13, 2024 at 2:17 PM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: >> >> On 12/06/2024 17:23, joswang wrote: >>> >>> + snps,p2p3tranok-quirk: >>> + description: >>> + When set, the controller transitions directly from phy power state >>> + P2 to P3 or from state P3 to P2. Note that this can only be set >>> + if the USB3 PHY supports direct p3 to p2 or p2 to p3 conversion. >>> + type: boolean >> >> Hm? You respond to feedback and, without waiting for my answer, >> immediately send new version? >> >> No. Read feedback on your previous version. Drop the quirk. >> >> Best regards, >> Krzysztof >> > > Thank you for your help in reviewing the code. > Sorry, I submitted three patches in total. Patch1 (the current patch) > and patch2 solve one case, and patch3 solves another case. Because > patch3 needs to submit a new version, I resubmitted v3 and v4 > versions. > Patch2 is under review, and there is no clear conclusion. For now, > patch1 does not need to be paid attention to. I will notify you when > patch2 has a clear conclusion. This does no work like this. Implement feedback and send new version of entire patchset *ONCE* there is conclusion. Sending new version of some parts ignoring feedback or skipping conclusion is not the way. Sorry. Still drop. Or in case we still have here misunderstanding - so far it looks like: NAK Best regards, Krzysztof
