On Thu, 13 Jun 2024 at 14:43, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote: > > > > On 5/24/2024 2:59 PM, Dmitry Baryshkov wrote: > > On Fri, 24 May 2024 at 11:23, Komal Bajaj <quic_kbajaj@xxxxxxxxxxx> wrote: > >> > >> While adding the USB support, it was found that the configuration > >> for regulator smps5 was incorrectly set. Upon cross verifying for > >> all the regulators, found that smps4, smps6 and smps8 are also > >> incorrectly configured. This patch fixes the same. > > > > Nit: see Documentation/process/submitting-patches.rst, "This patch..." > > Will update the commit message. > > > > >> In particular - > >> - smps4 is 1.574V min and 2.04V max > >> - smps5 is 1.2V min and 1.4V max > >> - smps6 is 0.382V min and 1.12V max > > > > Just for my understanding, will anything further constraint these values? > > As far as i know, this is going to be final. Ack > currently, usb device is not working without this min/max change. -- With best wishes Dmitry