On Thu, Jun 13, 2024 at 11:23:50AM +0200, Krzysztof Kozlowski wrote: > On 12/06/2024 20:43, Danila Tikhonov wrote: > > Document the DPU hardware found on the Qualcomm SM7150 platform. > > In general, this should be before MDSS, because it defines fully the > compatibles already used in the MDSS schema. For multi-binding devices > it always starts with children and ends with parent/top schema. > > > > > Signed-off-by: Danila Tikhonov <danila@xxxxxxxxxxx> > > --- > > .../bindings/display/msm/qcom,sm7150-dpu.yaml | 143 ++++++++++++++++++ > > 1 file changed, 143 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > > new file mode 100644 > > index 0000000000000..1a44cad131a72 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sm7150-dpu.yaml > > @@ -0,0 +1,143 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/msm/qcom,sm7150-dpu.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm SM7150 Display DPU > > What is DPU? Such acronyms should be explained in description or > expanded here, if there is space. Other bindings here use 'DPU', so probably we need to fix all of them at the same time. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > + > > +maintainers: > > + - Danila Tikhonov <danila@xxxxxxxxxxx> > > + > > +$ref: /schemas/display/msm/dpu-common.yaml# > > + > > +properties: > > + compatible: > > + const: qcom,sm7150-dpu > > + > > > > Best regards, > Krzysztof > -- With best wishes Dmitry
